From b5a63305173bda457dea8f03cb878a642665dca0 Mon Sep 17 00:00:00 2001
From: Pascal Serrarens <pse@pale.blue>
Date: Wed, 28 Aug 2024 12:33:20 +0200
Subject: [PATCH] Fix anglebetween

---
 Spherical.cpp | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/Spherical.cpp b/Spherical.cpp
index 5dabd01..3f76c37 100644
--- a/Spherical.cpp
+++ b/Spherical.cpp
@@ -217,14 +217,15 @@ AngleOf<T> SphericalOf<T>::AngleBetween(const SphericalOf& v1,
 
   Vector3 v1_3 = v1.ToVector3();
   Vector3 v2_3 = v2.ToVector3();
-  float dot = Vector3::Dot(v1_3, v2_3);
-  float fraction = dot / denominator;
-  if (isnan(fraction))
-    return fraction;  // short cut to returning NaN universally
+  // float dot = Vector3::Dot(v1_3, v2_3);
+  // float fraction = dot / denominator;
+  // if (isnan(fraction))
+  //   return fraction;  // short cut to returning NaN universally
 
-  float cdot = Float::Clamp(fraction, -1.0, 1.0);
-  float r = ((float)acos(cdot)) * Rad2Deg;
-  return r;
+  // float cdot = Float::Clamp(fraction, -1.0, 1.0);
+  // float r = ((float)acos(cdot)) * Rad2Deg;
+  Angle r = Vector3::Angle(v1_3, v2_3);
+  return AngleOf<T>(r.ToFloat());
 }
 
 template <typename T>